From f8d4aa47b6d9ffc7487d35598099971eb147d0ff Mon Sep 17 00:00:00 2001 From: Aaron Gokaslan Date: Tue, 11 Jan 2022 20:34:16 -0500 Subject: [PATCH] Add clang-tidy readability checks for sus args (#3611) --- .clang-tidy | 1 + tests/test_virtual_functions.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index dbe85a8b..d853a703 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -46,6 +46,7 @@ readability-simplify-subscript-expr, readability-static-accessed-through-instance, readability-static-definition-in-anonymous-namespace, readability-string-compare, +readability-suspicious-call-argument, readability-uniqueptr-delete-release, -bugprone-exception-escape, -bugprone-reserved-identifier, diff --git a/tests/test_virtual_functions.cpp b/tests/test_virtual_functions.cpp index f1a51318..d98b57f1 100644 --- a/tests/test_virtual_functions.cpp +++ b/tests/test_virtual_functions.cpp @@ -350,7 +350,7 @@ TEST_SUBMODULE(virtual_functions, m) { m.def("add3", [](const AdderBase::Data& first, const AdderBase::Data& second, const AdderBase::Data& third, const AdderBase& adder, const AdderBase::DataVisitor& visitor) { adder(first, second, [&] (const AdderBase::Data& first_plus_second) { - adder(first_plus_second, third, visitor); + adder(first_plus_second, third, visitor); // NOLINT(readability-suspicious-call-argument) }); });