From ed670055832f6669fbb7849878ed2cb99be4889c Mon Sep 17 00:00:00 2001 From: Wenzel Jakob Date: Sun, 22 Apr 2018 14:04:31 +0200 Subject: [PATCH] Minor fix for MSVC warning CS4459 (#1374) When using pybind11 to bind enums on MSVC and warnings (/W4) enabled, the following warning pollutes builds. This fix renames one of the occurrences. pybind11\include\pybind11\pybind11.h(1398): warning C4459: declaration of 'self' hides global declaration pybind11\include\pybind11\operators.h(41): note: see declaration of 'pybind11::detail::self' --- include/pybind11/pybind11.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/pybind11/pybind11.h b/include/pybind11/pybind11.h index 6947d440..a04d5365 100644 --- a/include/pybind11/pybind11.h +++ b/include/pybind11/pybind11.h @@ -1389,9 +1389,9 @@ public: } return pybind11::str("???"); }); - def_property_readonly_static("__doc__", [m_entries_ptr](handle self) { + def_property_readonly_static("__doc__", [m_entries_ptr](handle self_) { std::string docstring; - const char *tp_doc = ((PyTypeObject *) self.ptr())->tp_doc; + const char *tp_doc = ((PyTypeObject *) self_.ptr())->tp_doc; if (tp_doc) docstring += std::string(tp_doc) + "\n\n"; docstring += "Members:"; @@ -1404,7 +1404,7 @@ public: } return docstring; }); - def_property_readonly_static("__members__", [m_entries_ptr](handle /* self */) { + def_property_readonly_static("__members__", [m_entries_ptr](handle /* self_ */) { dict m; for (const auto &kv : reinterpret_borrow(m_entries_ptr)) m[kv.first] = kv.second[int_(0)];