From dbc4bf68edb28ab3c0faa2d0b9ab709248562c7e Mon Sep 17 00:00:00 2001 From: Jason Rhinelander Date: Sun, 28 Aug 2016 14:53:04 -0400 Subject: [PATCH] check-style: also report no space in if(/for(/while( --- tools/check-style.sh | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/tools/check-style.sh b/tools/check-style.sh index 412e67b5..c5ad5f74 100755 --- a/tools/check-style.sh +++ b/tools/check-style.sh @@ -6,14 +6,28 @@ # Invoke as: tools/check-style.sh # -found=0 -for f in `grep $'\t' include/ tests/ docs/*.rst -rl`; do - if [ "$found" -eq 0 ]; then +errors=0 +IFS=$'\n' +found= +grep $'\t' include/ tests/ docs/*.rst -rl | while read f; do + if [ -z "$found" ]; then echo -e '\e[31m\e[01mError: found tabs instead of spaces in the following files:\e[0m' found=1 + errors=1 fi echo " $f" done -exit $found +found= +grep '\<\(if\|for\|while\)(' include/ tests/* -r --color=always | while read line; do + if [ -z "$found" ]; then + echo -e '\e[31m\e[01mError: found the following coding style problems:\e[0m' + found=1 + errors=1 + fi + + echo " $line" +done + +exit $errors