From 6b4297fd2fe733d0bb7d57d1372cc3e4a15d7dbf Mon Sep 17 00:00:00 2001 From: Antony Lee Date: Tue, 22 Dec 2020 04:17:10 +0100 Subject: [PATCH] fix: don't trigger -Wunused-parameter in flagcheck.cpp. (#2735) ... by leaving the unused parameters anonymous. (This can be checked e.g. by compiling python_example with -Wall -Wextra.) --- pybind11/setup_helpers.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pybind11/setup_helpers.py b/pybind11/setup_helpers.py index 33605ddf..83e0bce1 100644 --- a/pybind11/setup_helpers.py +++ b/pybind11/setup_helpers.py @@ -232,7 +232,8 @@ def has_flag(compiler, flag): with tmp_chdir(): fname = "flagcheck.cpp" with open(fname, "w") as f: - f.write("int main (int argc, char **argv) { return 0; }") + # Don't trigger -Wunused-parameter. + f.write("int main (int, char **) { return 0; }") try: compiler.compile([fname], extra_postargs=[flag])