RYDE-WORK/pybind11
1
0
Fork 0
mirror of https://github.com/RYDE-WORK/pybind11.git synced 2026-02-05 23:13:36 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Properly report exceptions thrown during module initialization.

Browse Source 
If an exception is thrown during module initialization, the
error_already_set destructor will try to call `get_internals()` *after*
setting Python's error indicator, resulting in a `SystemError: ...
returned with an error set`.

Fix that by temporarily stashing away the error indicator in the
destructor.
This commit is contained in:
Antony Lee 2018-04-16 19:08:45 -07:00 committed by Jason Rhinelander
parent 55dc131944
commit 58e551cc73
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/pybind11/pybind11.h
View File

@ -1894,6 +1894,7 @@ class gil_scoped_release { };
error_already_set::~error_already_set() { error_already_set::~error_already_set() {
if (type) { if (type) {
error_scope scope;
gil_scoped_acquire gil; gil_scoped_acquire gil;
type.release().dec_ref(); type.release().dec_ref();
value.release().dec_ref(); value.release().dec_ref();