RYDE-WORK/ballistica
1
0
Fork 0
mirror of https://github.com/RYDE-WORK/ballistica.git synced 2026-02-06 23:59:18 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Simplifying some thread pool worker counts to just use cpu_count

Browse Source
This commit is contained in:
Eric Froemling 2020-05-10 13:16:51 -07:00
parent fab6a54ff8
commit c3b5a8807c
1 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tools/efrotools/code.py
View File

@ -66,13 +66,8 @@ def formatcode(projroot: Path, full: bool) -> None:
sys.stdout.flush() sys.stdout.flush()
return {'f': filename, 't': duration} return {'f': filename, 't': duration}
# NOTE: using fewer workers than we have logical procs for now; with concurrent.futures.ThreadPoolExecutor(
# we're bottlenecked by one or two long running instances max_workers=cpu_count()) as executor:
# so it actually helps to lighten the load around them.
# may want to revisit later when we have everything chopped up
# better
with concurrent.futures.ThreadPoolExecutor(max_workers=cpu_count() //
2) as executor:
# Converting this to a list will propagate any errors. # Converting this to a list will propagate any errors.
list(executor.map(format_file, dirtyfiles)) list(executor.map(format_file, dirtyfiles))
@ -122,7 +117,7 @@ def cpplint(projroot: Path, full: bool) -> None:
if result != 0: if result != 0:
raise Exception(f'Linting failed for {filename}') raise Exception(f'Linting failed for {filename}')
with ThreadPoolExecutor(max_workers=cpu_count() // 2) as executor: with ThreadPoolExecutor(max_workers=cpu_count()) as executor:
# Converting this to a list will propagate any errors. # Converting this to a list will propagate any errors.
list(executor.map(lint_file, dirtyfiles)) list(executor.map(lint_file, dirtyfiles))
@ -178,12 +173,7 @@ def formatscripts(projroot: Path, full: bool) -> None:
print(f'Formatted {filename} in {duration:.2f} seconds.') print(f'Formatted {filename} in {duration:.2f} seconds.')
sys.stdout.flush() sys.stdout.flush()
# NOTE: using fewer workers than we have logical procs for now; with ThreadPoolExecutor(max_workers=cpu_count()) as executor:
# we're bottlenecked by one or two long running instances
# so it actually helps to lighten the load around them.
# may want to revisit later when we have everything chopped up
# better
with ThreadPoolExecutor(max_workers=cpu_count() // 2) as executor:
# Convert the futures to a list to propagate any errors even # Convert the futures to a list to propagate any errors even
# though there are no return values we use. # though there are no return values we use.
list(executor.map(format_file, dirtyfiles)) list(executor.map(format_file, dirtyfiles))