Fixed if __debug__ statements so they are properly optimized out

This commit is contained in:
Eric Froemling 2020-04-06 16:20:14 -07:00
parent 8b0b332f1a
commit b3f656ade7
11 changed files with 22 additions and 15 deletions

View File

@ -48,6 +48,7 @@
<scope name="UncheckedPython" level="WEAK WARNING" enabled="false" />
</inspection_tool>
<inspection_tool class="PyTypeCheckerInspection" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="PyUnreachableCodeInspection" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="PyUnresolvedReferencesInspection" enabled="true" level="WARNING" enabled_by_default="true">
<scope name="PyIgnoreUnresolved" level="WARNING" enabled="false">
<option name="ignoredIdentifiers">

View File

@ -72,7 +72,7 @@ class CoopSession(Session):
except Exception:
max_players = 4
print('FIXME: COOP SESSION WOULD CALC DEPS.')
# print('FIXME: COOP SESSION WOULD CALC DEPS.')
depsets: Sequence[ba.DependencySet] = []
super().__init__(depsets,

View File

@ -150,7 +150,7 @@ class Background(ba.Actor):
ba.timer(self.fade_time + 0.1, self.node.delete)
def handlemessage(self, msg: Any) -> Any:
if __debug__ is True:
if __debug__:
self._handlemessage_sanity_check()
if isinstance(msg, ba.DieMessage):
self._die(msg.immediate)

View File

@ -469,7 +469,7 @@ class ControlsGuide(ba.Actor):
return not self._dead
def handlemessage(self, msg: Any) -> Any:
if __debug__ is True:
if __debug__:
self._handlemessage_sanity_check()
if isinstance(msg, ba.DieMessage):
if msg.immediate:

View File

@ -51,8 +51,9 @@ class Image(ba.Actor):
# pylint: disable=too-many-branches
# pylint: disable=too-many-locals
super().__init__()
# if they provided a dict as texture, assume its an icon..
# otherwise its just a texture value itself
# If they provided a dict as texture, assume its an icon.
# otherwise its just a texture value itself.
mask_texture: Optional[ba.Texture]
if isinstance(texture, dict):
tint_color = texture['tint_color']
@ -156,13 +157,13 @@ class Image(ba.Actor):
cmb.input1 = position[1]
cmb.connectattr('output', self.node, 'position')
# if we're transitioning out, die at the end of it
# If we're transitioning out, die at the end of it.
if transition_out_delay is not None:
ba.timer(transition_delay + transition_out_delay + 1.0,
ba.WeakCall(self.handlemessage, ba.DieMessage()))
def handlemessage(self, msg: Any) -> Any:
if __debug__ is True:
if __debug__:
self._handlemessage_sanity_check()
if isinstance(msg, ba.DieMessage):
if self.node:

View File

@ -122,7 +122,7 @@ class PopupText(ba.Actor):
lifespan, ba.WeakCall(self.handlemessage, ba.DieMessage()))
def handlemessage(self, msg: Any) -> Any:
if __debug__ is True:
if __debug__:
self._handlemessage_sanity_check()
if isinstance(msg, ba.DieMessage):
if self.node:

View File

@ -128,8 +128,10 @@ class Spaz(ba.Actor):
else:
self._punch_power_scale = factory.punch_power_scale
self.fly = ba.sharedobj('globals').happy_thoughts_mode
assert isinstance(activity, ba.GameActivity)
self._hockey = activity.map.is_hockey
if isinstance(activity, ba.GameActivity):
self._hockey = activity.map.is_hockey
else:
self._hockey = False
self._punched_nodes: Set[ba.Node] = set()
self._cursed = False
self._connected_to_player: Optional[ba.Player] = None
@ -693,7 +695,7 @@ class Spaz(ba.Actor):
# pylint: disable=too-many-return-statements
# pylint: disable=too-many-statements
# pylint: disable=too-many-branches
if __debug__ is True:
if __debug__:
self._handlemessage_sanity_check()
if isinstance(msg, ba.PickedUpMessage):
@ -1122,6 +1124,7 @@ class Spaz(ba.Actor):
elif isinstance(msg, ba.OutOfBoundsMessage):
# By default we just die here.
self.handlemessage(ba.DieMessage(how=ba.DeathType.FALL))
elif isinstance(msg, ba.StandMessage):
self._last_stand_pos = (msg.position[0], msg.position[1],
msg.position[2])
@ -1129,8 +1132,10 @@ class Spaz(ba.Actor):
self.node.handlemessage("stand", msg.position[0],
msg.position[1], msg.position[2],
msg.angle)
elif isinstance(msg, CurseExplodeMessage):
self.curse_explode()
elif isinstance(msg, PunchHitMessage):
if not self.node:
return None

View File

@ -191,7 +191,7 @@ class Text(ba.Actor):
ba.WeakCall(self.handlemessage, ba.DieMessage()))
def handlemessage(self, msg: Any) -> Any:
if __debug__ is True:
if __debug__:
self._handlemessage_sanity_check()
if isinstance(msg, ba.DieMessage):
if self.node:

View File

@ -103,7 +103,7 @@ class TipsText(ba.Actor):
self.node.text = next_tip
def handlemessage(self, msg: Any) -> Any:
if __debug__ is True:
if __debug__:
self._handlemessage_sanity_check()
if isinstance(msg, ba.DieMessage):
if self.node:

View File

@ -171,7 +171,7 @@ class ZoomText(ba.Actor):
ba.DieMessage()))
def handlemessage(self, msg: Any) -> Any:
if __debug__ is True:
if __debug__:
self._handlemessage_sanity_check()
if isinstance(msg, ba.DieMessage):
if not self._dying and self.node:

View File

@ -96,7 +96,7 @@ class CompoundField(BaseField, Generic[TC]):
value: TC,
store_default: bool = True) -> None:
super().__init__(d_key)
if __debug__ is True:
if __debug__:
from efro.entity._value import CompoundValue
assert isinstance(value, CompoundValue)
assert not hasattr(value, 'd_data')