From 70138a9a23b66a198c16861fa7bbd2e30065d770 Mon Sep 17 00:00:00 2001 From: Eric Froemling Date: Fri, 13 Dec 2019 17:44:08 -0800 Subject: [PATCH] minor tools cleanup --- tools/efrotools/code.py | 4 ++-- tools/efrotools/efrocache.py | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/efrotools/code.py b/tools/efrotools/code.py index 0df1578b..f63302a7 100644 --- a/tools/efrotools/code.py +++ b/tools/efrotools/code.py @@ -62,7 +62,7 @@ def formatcode(projroot: Path, full: bool) -> None: if result != 0: raise Exception(f'Formatting failed for {filename}') duration = time.time() - start_time - print(f'Formatted {filename} in {duration:.2f} seconds') + print(f'Formatted {filename} in {duration:.2f} seconds.') sys.stdout.flush() return {'f': filename, 't': duration} @@ -175,7 +175,7 @@ def formatscripts(projroot: Path, full: bool) -> None: if result != 0: raise Exception(f'Formatting failed for {filename}') duration = time.time() - start_time - print(f'Formatted {filename} in {duration:.2f} seconds') + print(f'Formatted {filename} in {duration:.2f} seconds.') sys.stdout.flush() # NOTE: using fewer workers than we have logical procs for now; diff --git a/tools/efrotools/efrocache.py b/tools/efrotools/efrocache.py index acf55684..129d9309 100644 --- a/tools/efrotools/efrocache.py +++ b/tools/efrotools/efrocache.py @@ -258,6 +258,10 @@ def _write_cache_files(fnames1: List[str], fnames2: List[str], for result in results: mapping[result[0]] = BASE_URL + result[1] + # FIXME - we could save significant bandwidth by assembling the + # starter cache on the server instead of locally and then uploading it. + # (we have to sync all its comprising files to the server anyway) + # Once we've written our first set, create # a starter-cache file from everything we wrote. # This consists of some subset of the cache dir we just filled out.