From f6802dfed0f15510942620cff6ca4b6282e9ffb9 Mon Sep 17 00:00:00 2001 From: Roman Trapeznikov Date: Sat, 11 Apr 2020 15:02:46 +0300 Subject: [PATCH 1/3] fix ffa session --- assets/src/ba_data/python/ba/_session.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/assets/src/ba_data/python/ba/_session.py b/assets/src/ba_data/python/ba/_session.py index 52671049..10d43c76 100644 --- a/assets/src/ba_data/python/ba/_session.py +++ b/assets/src/ba_data/python/ba/_session.py @@ -146,11 +146,6 @@ class Session: # print('Would set host-session asset-reqs to:', # required_asset_packages) - if team_names is None: - team_names = ['Good Guys'] - if team_colors is None: - team_colors = [(0.6, 0.2, 1.0)] - # First thing, wire up our internal engine data. self._sessiondata = _ba.register_session(self) From 337045c9f84d10027f108f76f6091f1f983f38a5 Mon Sep 17 00:00:00 2001 From: Roman Trapeznikov Date: Sat, 11 Apr 2020 15:35:45 +0300 Subject: [PATCH 2/3] type-checking --- assets/src/ba_data/python/ba/_session.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/assets/src/ba_data/python/ba/_session.py b/assets/src/ba_data/python/ba/_session.py index 10d43c76..c5f774ca 100644 --- a/assets/src/ba_data/python/ba/_session.py +++ b/assets/src/ba_data/python/ba/_session.py @@ -192,6 +192,8 @@ class Session: self.max_players = max_players if self._use_teams: + assert team_names is not None + assert team_colors is not None for i, color in enumerate(team_colors): team = Team(team_id=self._next_team_id, name=GameActivity.get_team_display_string( From 8f9a7c4ac61e410d085159d4fff366c12b679772 Mon Sep 17 00:00:00 2001 From: Roman Trapeznikov Date: Sat, 11 Apr 2020 15:54:58 +0300 Subject: [PATCH 3/3] enable pylint: too-many-branches --- assets/src/ba_data/python/ba/_session.py | 1 - 1 file changed, 1 deletion(-) diff --git a/assets/src/ba_data/python/ba/_session.py b/assets/src/ba_data/python/ba/_session.py index c5f774ca..b1b56d4a 100644 --- a/assets/src/ba_data/python/ba/_session.py +++ b/assets/src/ba_data/python/ba/_session.py @@ -97,7 +97,6 @@ class Session: instances; one for each ba.Activity the session may potentially run. """ # pylint: disable=too-many-statements - # pylint: disable=too-many-branches # pylint: disable=too-many-locals # pylint: disable=cyclic-import from ba._lobby import Lobby