From cae2ee76422e8b34e0ac9cdea0ca5c0686032922 Mon Sep 17 00:00:00 2001 From: TrialTemp Date: Thu, 11 Jan 2024 23:56:50 -0600 Subject: [PATCH 1/3] meteor showered :) --- src/assets/ba_data/python/bascenev1lib/game/meteorshower.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/assets/ba_data/python/bascenev1lib/game/meteorshower.py b/src/assets/ba_data/python/bascenev1lib/game/meteorshower.py index 35e0566d..964b6452 100644 --- a/src/assets/ba_data/python/bascenev1lib/game/meteorshower.py +++ b/src/assets/ba_data/python/bascenev1lib/game/meteorshower.py @@ -69,6 +69,7 @@ class MeteorShowerGame(bs.TeamGameActivity[Player, Team]): self._last_player_death_time: float | None = None self._meteor_time = 2.0 self._timer: OnScreenTimer | None = None + self._ended: bool = False # Some base class overrides: self.default_music = ( @@ -153,6 +154,9 @@ class MeteorShowerGame(bs.TeamGameActivity[Player, Team]): return None def _check_end_game(self) -> None: + # We don't want to end this activity more than once. + if self._ended: return + living_team_count = 0 for team in self.teams: for player in team.players: @@ -261,4 +265,5 @@ class MeteorShowerGame(bs.TeamGameActivity[Player, Team]): # Submit the score value in milliseconds. results.set_team_score(team, int(1000.0 * longest_life)) + self._ended = True self.end(results=results) From bd47a61f2f5063ec40d6de12d1b194b0bfc984bd Mon Sep 17 00:00:00 2001 From: TrialTemp Date: Thu, 11 Jan 2024 23:57:23 -0600 Subject: [PATCH 2/3] look --- CONTRIBUTORS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 8fccc544..626648a1 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -50,3 +50,6 @@ ### Rikko - Created the original "reject_recently_left_players" plugin + +### Temp (3alTemp) +- Modder & Bug Fixer \ No newline at end of file From 6910e303870244741b434b41bff80961d4dcca3d Mon Sep 17 00:00:00 2001 From: TrialTemp Date: Thu, 25 Jan 2024 16:02:00 -0600 Subject: [PATCH 3/3] pylinted --- src/assets/ba_data/python/bascenev1lib/game/meteorshower.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/assets/ba_data/python/bascenev1lib/game/meteorshower.py b/src/assets/ba_data/python/bascenev1lib/game/meteorshower.py index 964b6452..80e2cd40 100644 --- a/src/assets/ba_data/python/bascenev1lib/game/meteorshower.py +++ b/src/assets/ba_data/python/bascenev1lib/game/meteorshower.py @@ -155,8 +155,9 @@ class MeteorShowerGame(bs.TeamGameActivity[Player, Team]): def _check_end_game(self) -> None: # We don't want to end this activity more than once. - if self._ended: return - + if self._ended: + return + living_team_count = 0 for team in self.teams: for player in team.players: