From 2510f2946e8e461734ed9ea0097b3f94f1b01d73 Mon Sep 17 00:00:00 2001
From: Eric Froemling <ericfroemling@gmail.com>
Date: Thu, 26 Mar 2020 19:53:16 -0700
Subject: [PATCH] added windows unit testing

---
 .github/workflows/ci.yml     | 9 +++++++--
 .idea/dictionaries/ericf.xml | 1 +
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 99529eed..4b33ee25 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -8,7 +8,9 @@ on:
       - cron: '0 12 * * *'
         
 jobs:
-  
+
+  # We run most of our testing on linux but it should apply to mac too;
+  # we can always add an explicit mac job if it seems worthwhile.
   ci_unix:
     runs-on: ubuntu-18.04
     steps:
@@ -21,7 +23,10 @@ jobs:
       run: tools/snippets install_pip_reqs
     - name: Run checks and tests
       run: make -j2 check test
-      
+
+  # Most of our toolset doesn't work on raw windows (outside of WSL).
+  # However, it's nice to at least run unit tests there since some behavior
+  # (filesystem, etc) can vary significantly.
   ci_windows:
     runs-on: windows-latest
     steps:
diff --git a/.idea/dictionaries/ericf.xml b/.idea/dictionaries/ericf.xml
index 08a0a985..1e9fa01d 100644
--- a/.idea/dictionaries/ericf.xml
+++ b/.idea/dictionaries/ericf.xml
@@ -308,6 +308,7 @@
       <w>completecmd</w>
       <w>compounddict</w>
       <w>compoundlist</w>
+      <w>conditionalize</w>
       <w>configerror</w>
       <w>confighash</w>
       <w>configkey</w>