From b9827529aad9d565e2f2ef90e96632ed628a7d40 Mon Sep 17 00:00:00 2001 From: af su <53895794+vegetablest@users.noreply.github.com> Date: Mon, 20 May 2024 14:44:02 +0800 Subject: [PATCH] fix: incorrect variable usage in update_doc_by_ids method (#4048) Co-authored-by: saf --- server/knowledge_base/kb_service/base.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/server/knowledge_base/kb_service/base.py b/server/knowledge_base/kb_service/base.py index c83753d5..5990903e 100644 --- a/server/knowledge_base/kb_service/base.py +++ b/server/knowledge_base/kb_service/base.py @@ -194,14 +194,14 @@ class KBService(ABC): 如果对应 doc_id 的值为 None，或其 page_content 为空，则删除该文档 ''' self.del_doc_by_ids(list(docs.keys())) - docs = [] + pending_docs = [] ids = [] - for k, v in docs.items(): - if not v or not v.page_content.strip(): + for _id, doc in docs.items(): + if not doc or not doc.page_content.strip(): continue - ids.append(k) - docs.append(v) - self.do_add_doc(docs=docs, ids=ids) + ids.append(_id) + pending_docs.append(doc) + self.do_add_doc(docs=pending_docs, ids=ids) return True def list_docs(self, file_name: str = None, metadata: Dict = {}) -> List[DocumentWithVSId]: